Skip to content
This repository has been archived by the owner on Apr 5, 2018. It is now read-only.

Updated to node v7.8.0 #2

Merged
merged 4 commits into from
Apr 6, 2017
Merged

Updated to node v7.8.0 #2

merged 4 commits into from
Apr 6, 2017

Conversation

mcollina
Copy link
Collaborator

@mcollina mcollina commented Apr 4, 2017

As titled, this is based on the latest build scripts from readable-stream.

It needs an iteration on the README.

On which version do we want to publish? 2 as readable-stream?
I think it deserves a major bump.

cc @calvinmetcalf

@mcollina
Copy link
Collaborator Author

mcollina commented Apr 4, 2017

@rvagg can you please enable travis, so that we can test in all platforms?

@calvinmetcalf
Copy link

it would be 1.0.0 if we were going by readable stream

@mcollina
Copy link
Collaborator Author

mcollina commented Apr 4, 2017

This is the current result from npm show string_decoder:

{ name: 'string_decoder',
  description: 'The string_decoder module from Node core',
  'dist-tags': { latest: '0.10.31' },
  versions:
   [ '0.0.0',
     '0.0.1',
     '0.10.24',
     '0.10.25-1',
     '0.10.25',
     '0.10.31',
     '0.11.10-1',
     '0.11.10' ],
  maintainers: [ 'substack <[email protected]>', 'rvagg <[email protected]>' ],
  time:
   { modified: '2016-11-01T18:40:08.313Z',
     created: '2013-12-03T20:13:26.191Z',
     '0.0.0': '2013-12-03T20:13:27.743Z',
     '0.0.1': '2014-01-17T19:53:23.612Z',
     '0.10.24': '2014-01-18T05:27:35.195Z',
     '0.11.10': '2014-01-18T05:28:38.924Z',
     '0.10.25': '2014-01-28T02:21:38.263Z',
     '0.11.10-1': '2014-01-28T02:24:31.052Z',
     '0.10.25-1': '2014-02-12T09:51:56.014Z',
     '0.10.31': '2014-08-23T04:25:19.329Z' },
  repository:
   { type: 'git',
     url: 'git://github.com/rvagg/string_decoder.git' },
  readmeFilename: 'README.md',
  users:
   { wenbing: true,
     simplyianm: true,
     xgqfrms: true,
     mojaray2k: true },
  homepage: 'https://github.com/rvagg/string_decoder',
  keywords: [ 'string', 'decoder', 'browser', 'browserify' ],
  bugs: { url: 'https://github.com/rvagg/string_decoder/issues' },
  license: 'MIT',
  version: '0.10.31',
  main: 'index.js',
  dependencies: {},
  devDependencies: { tap: '~0.4.8' },
  scripts: { test: 'tap test/simple/*.js' },
  gitHead: 'd46d4fd87cf1d06e031c23f1ba170ca7d4ade9a0',
  dist:
   { shasum: '62e203bc41766c6c28c9fc84301dab1c5310fa94',
     tarball: 'https://registry.npmjs.org/string_decoder/-/string_decoder-0.10.31.tgz' },
  directories: {} }

@mcollina
Copy link
Collaborator Author

mcollina commented Apr 6, 2017

@calvinmetcalf can you review this? Are you ok to release as v1.0.0?

Copy link

@calvinmetcalf calvinmetcalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not using template strings isn't really a blocker, we can move over to them in the future pretty easily

+ '\n switch (encoding && encoding.toLowerCase()) {'
+ '\n case \'hex\': case \'utf8\': case \'utf-8\': case \'ascii\': case \'binary\': case \'base64\': case \'ucs2\': case \'ucs-2\': case \'utf16le\': case \'utf-16le\': case \'raw\': return true;'
+ '\n default: return false;'
+ '\n }'
+ '\n }'
+ '\n'

+ '\nfunction _normalizeEncoding(enc) {'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if your doing it from scratch I highly recomend tempalte strings instead of this stuff, one million times easier to edit

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, but I copied and pasted this :).

@mcollina mcollina merged commit 5dd33eb into master Apr 6, 2017
@mcollina mcollina deleted the update-to-latest-core branch April 6, 2017 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants