Fix this.connected bug when connect event is missed#96
Open
willyjchen wants to merge 2 commits intorv-kip:masterfrom
Open
Fix this.connected bug when connect event is missed#96willyjchen wants to merge 2 commits intorv-kip:masterfrom
willyjchen wants to merge 2 commits intorv-kip:masterfrom
Conversation
This fix a bug that this.connected is not initialized if the redis connect event is missed. Check if the connect event is missed or not, then emit the missed connect event again.
atn18
suggested changes
Feb 18, 2020
lib/ExpressRedisCache.js
Outdated
| }.bind(this)); | ||
|
|
||
| if ( this.client.connected ) { | ||
| this.client.emit('connect'); |
There was a problem hiding this comment.
I think resending connect on client is not good idea. Because there could be some subscribers that will not expect this.
You should better directly set self.connected.
1. Avoid resenting redis 'connect' event as suggested change 2. Add check of 'this.connected' to prevent init twice
atn18
approved these changes
Feb 19, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix a bug that this.connected is not initialized if the redis connect event is missed.
Check if the connect event is missed or not, then emit the missed connect event again.