Extend usage to restify#71
Open
willfarrell wants to merge 2 commits intorv-kip:masterfrom
willfarrell:patch-1
Open
Extend usage to restify#71willfarrell wants to merge 2 commits intorv-kip:masterfrom willfarrell:patch-1
willfarrell wants to merge 2 commits intorv-kip:masterfrom
willfarrell:patch-1
Conversation
when using restify; res.contentType generates:
```
{ [TypeError: res.contentType is not a function]
domain:
Domain {
domain: null,
_events: { error: [Function] },
_eventsCount: 1,
_maxListeners: undefined,
members: [] },
domainThrown: true }
```
lib/ExpressRedisCache/route.js
Outdated
| res.contentType(cache[0].type || "text/html"); | ||
| } else if (res.setHeader) { | ||
| res.setHeader('content-type', cache[0].type || "text/html"); | ||
| } |
Contributor
There was a problem hiding this comment.
Looks like spaces are being used elsewhere in this project. Would you consider uses spaces instead of tabs for consistency?
Author
There was a problem hiding this comment.
lol, serves me right for doing it in the browser. All fixed.
markberryman
reviewed
Dec 1, 2016
|
|
||
| if ( cache.length ) { | ||
| res.contentType(cache[0].type || "text/html"); | ||
| if (res.contentType) { |
There was a problem hiding this comment.
I think we can avoid this conditional by using res.header which is supported by Express v4.x and Restify.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when using restify; res.contentType generates: