store and retrieve response status code#65
Merged
krazyjakee merged 3 commits intorv-kip:masterfrom Sep 11, 2018
Merged
Conversation
Owner
|
If this pull request is still desired, please fix the conflicts and we'll get it merged. Otherwise, please close. |
Conflicts: lib/ExpressRedisCache/route.js
Contributor
Author
|
fixed |
|
This PR will be merged some day ? I'm still facing this bug which return a |
Contributor
Author
|
I wish it was. |
|
Hi, the PR was merged but the latest version does not include it. Can we get a version bump? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction that stores and serves from cache http response status codes. This is important when for example part of application crashes after expensive computing and returns "500" to web browser. When responding with 200 status code and error message, response can be for example cached client side.