Fix for response hang if status was not present in cached response#120
Open
Yurko-Fedoriv wants to merge 2 commits intorv-kip:masterfrom
Open
Fix for response hang if status was not present in cached response#120Yurko-Fedoriv wants to merge 2 commits intorv-kip:masterfrom
Yurko-Fedoriv wants to merge 2 commits intorv-kip:masterfrom
Conversation
atn18
suggested changes
Feb 10, 2020
…lder lib) * disregard cache if status is unknown
atn18
approved these changes
Feb 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the cached response was created by an older lib version which would not store Status Code, express-redis-case would set
which for me caused requests to hang forever.
Having the default status makes it transparently transition to storing response status.