endian.h: Guard against __{BIG,LITTLE}_ENDIAN being defined #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiled on FreeBSD, we get both __LITTLE_ENDIAN and __BIG_ENDIAN defined. glibc defines these as well, but it defines them to 1234 and 4321. However, FreeBSD defines them to __ORDER_LITTLE_ENDIAN__ and __ORDER_BIG_ENDIAN__ to take advantage of the recent gcc and clang predefines. Check to see if __LITTLE_ENDIAN is defined before we redefine it. This is less than perfect, I'll grant, but anything starting with __ is in the implementation namespace so some care needs to be taken. Signed-off-by: Warner Losh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiled on FreeBSD, we get both __LITTLE_ENDIAN and __BIG_ENDIAN defined. glibc defines these as well, but it defines them to 1234 and
4321. However, FreeBSD defines them to ORDER_LITTLE_ENDIAN and ORDER_BIG_ENDIAN to take advantage of the recent gcc and clang predefines. Check to see if __LITTLE_ENDIAN is defined before we redefine it. This is less than perfect, I'll grant, but anything starting with __ is in the implementation namespace so some care needs to be taken.