This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Fixes allocator to reflect changes in nightly API #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x7CFE
commented
Jun 13, 2018
wee_alloc/src/imp_static_array.rs
Outdated
| @@ -1,5 +1,5 @@ | |||
| use const_init::ConstInit; | |||
| use core::alloc::{AllocErr, Opaque}; | |||
| use core::alloc::{AllocErr, u8}; | |||
Contributor
Author
There was a problem hiding this comment.
Oops, that was too verbose :) Gonna fix that in a sec.
Collaborator
|
For the first issue, I would refer to https://users.rust-lang.org/t/psa-breaking-change-panic-fmt-language-item-removed-in-favor-of-panic-implementation/17875 , regarding the switch from |
Contributor
Author
@ZackPierce, thank you for the link. I think I can handle that. |
Contributor
Author
|
@ZackPierce, I've fixed all issues and now As for the remaining two issues, looks like it was me accidentally running normal |
0x7CFE
added a commit
to paritytech/substrate
that referenced
this pull request
Jun 15, 2018
Revision 4e9f23f points to a master after rustwasm/wee_alloc#45 was merged
rphmeier
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Aug 14, 2018
Revision 4e9f23f points to a master after rustwasm/wee_alloc#45 was merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes in nightly broke
wee_allocbuild. In an attempt to solve the issues I prepared the following PR.Unfortunately, not all changes are resolved at the moment, so I would really appreciate any suggestions and comments on the remaining issues.
Currently there are three of them:
panic_fmtatexample/src/lib.rs:21:1duplicate lang item found:oomatexample/src/lib.rs:31:1duplicate lang item found:eh_personalityatexample/src/lib.rs:39:1Aside of that, the rest of the code compiles successfully.