Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check wasm-bindgen version if running with target web #684

Merged
merged 12 commits into from
Jul 17, 2019
Merged

check wasm-bindgen version if running with target web #684

merged 12 commits into from
Jul 17, 2019

Conversation

ashleygwilliams
Copy link
Member

#633 with merge, edits, and test

Kirk Turner and others added 3 commits April 21, 2019 22:48
#627 - create a custom error message when wasm-bindgen fails because …
97fdc94 
…--web isn't available

Change the return type of the child run commands so it can return a CommandError that also captures the stderr if the process fails.
See if the returned output contains the 'Unknown flag: --web' error message and if so provide an alternative error that suggests upgrading
Get the wasm-bindgen version and display it in the error message
64f835c
@ashleygwilliams
Merge branch '627-bindgen-version-error' of https://github.com/gameld…
5b04325 
…ar/wasm-pack into gameldar-627-bindgen-version-error
@ashleygwilliams ashleygwilliams added the work in progress do not merge! label Jul 16, 2019
@ashleygwilliams ashleygwilliams added this to the 0.9.0 milestone Jul 16, 2019
@ashleygwilliams ashleygwilliams mentioned this pull request Jul 16, 2019
Closed
@ashleygwilliams ashleygwilliams added the needs tests please add tests to this PR label Jul 16, 2019
@ashleygwilliams ashleygwilliams force-pushed the gameldar-627-bindgen-version-error branch 2 times, most recently from 6a3e980 to 9c2ca6c Compare July 16, 2019 20:40
@ashleygwilliams ashleygwilliams force-pushed the gameldar-627-bindgen-version-error branch from 9c2ca6c to b72048b Compare July 16, 2019 20:41
@ashleygwilliams ashleygwilliams force-pushed the gameldar-627-bindgen-version-error branch from cf2b01a to 0a3bc9a Compare July 16, 2019 22:29
@ashleygwilliams ashleygwilliams force-pushed the gameldar-627-bindgen-version-error branch from 0a3bc9a to 032c9f4 Compare July 16, 2019 22:49
@ashleygwilliams ashleygwilliams changed the title [WIP] #633 with merge, edits, and test check wasm-bindgen version if running with target web Jul 16, 2019
@ashleygwilliams ashleygwilliams added needs review and removed needs tests please add tests to this PR work in progress do not merge! labels Jul 16, 2019
@ashleygwilliams
Copy link
Member Author

CI should fail on branch but not PR on debug assertions test bug that has already been fixed on master

@alexcrichton
Copy link
Contributor

👍

@alexcrichton alexcrichton merged commit 2a7e6ac into master Jul 17, 2019
@alexcrichton alexcrichton deleted the gameldar-627-bindgen-version-error branch July 17, 2019 15:16
@EverlastingBugstopper EverlastingBugstopper mentioned this pull request Jan 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

@fitzgen fitzgen Awaiting requested review from fitzgen

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleygwilliams @alexcrichton