-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add user agent for wasm-pack version check #658
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks @drager :)
It seems like CI has been failing for all the PRs recently and seems sort of related to |
@fitzgen Hmm, I haven't really dug in the latest changes for binary-install just yet. Maybe @ashleygwilliams have an idea? This is the test that fails though: Lines 24 to 69 in b07ec95
|
merging as this change is not related to the CI failure |
This PR adds a user agent header for the wasm-pack version check. It will look like this:
User-Agent: wasm-pack/0.8.1 (https://github.com/rustwasm/wasm-pack)
.Fixes #651.