-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-build before wasm-pack publish #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so- i think this is great! the one thing i'd add is that the "magic" of this feature is that it will build your project for you with the defaults. i think this is 100% in line with the design values of wasm-pack, but for the sake of the end user, i think we should emit a warning/info that says that wasm-pack has built your project with the defaults (pkg
dir, and for es6
(browser
target)). if you could add that i think we'll be good to merge.
if we really wanted to expand this, we could instead prompt the user if they want the project built (or if they want to cancel), and then ask them for the target they prefer. let me know what you think about that! (to skip the interactive element someone could pass wasm-pack publish --target <intended target>
)
@ashleygwilliams that's great, so I'll expand the features soon as you wrote. |
@ashleygwilliams pre-build flow:
|
f144939
to
79f6776
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@csmoe this is looking AWESOME! thanks so much- do you think we could change the prompt from npm package
to just package
? it may also be nice to list the defaults/options for out dir and target options when prompting (e.g. when you run npm init
it will show the default and you can just choose it or override) - we could also add that in a separate PR :)
so yeah, to merge- let's just switch npm package to just package- and if you'd like to, add the defaults/options
it already does, default options indicated within |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fantastic! thank you so much!!
@ashleygwilliams btw, may I still have your invitation of rustwasm-org as we talked in twitter several months ago? |
oh yes! i'll take care of that today :) |
Closes #438