Change to INFO when alerting users about missing fields Cargo.toml #394
Conversation
|
@ashleygwilliams No problem, I'm up for updating this PR to reflect whatever we think is the less scary way to inform users of the missing fields! |
|
@mstallmo if you're up for it, would you be willing to implement this feature where the missing fields are a single INFO? i think that's probably the best case here |
|
Will do! I can probably get to this in the next couple of hours over lunch. For formatting I’m assuming we just want to have the missing fields separated by commas in the INFO line? |
|
@mstallmo yeah, separated by commas sounds good to me, e.g. "Optional fields missing from Cargo.toml: 'x', 'x', 'x'. These are not necessary but recommended." |
I think switching both to INFO and to single line is good 👍 |
|
I've updated to combine the INFO print out to one line with fields separated by commas. I've attached pictures how the print out looks with the various combinations of printout:
Side note: It looks like running rustfmt on the mod.rs file picked up a change with how |
|
@mstallmo appreciate the note on the diff but i think it's fine :) this all looks awesome- thanks for your efforts. waiting on CI to be green but i think we can merge this! |
|
Welp, just ran cargo fmt and it looks like the formatting for visual studio on my Mac was not configured correctly. I fixed the issue and updated. |
Change to INFO when alerting users about missing fields in Cargo.toml Combine filed missing messages into one INFO line Fix bad formating Merge pull request rustwasm#394 from mstallmo/master Change to INFO when alerting users about missing fields Cargo.toml child: Always print everything to our output Also don't buffer the child's stdout and stderr. error: Add stdout to the `Error::Cli` variant refactor: Return failure::Error instead of wasm_pack::error::Error refactor: Import self and use full module path for failure Use full module path for failure to be consistent since it's used like that in other modules. refactor: Return failure::Error instead of wasm_pack::error::Error chore: Run rustfmt chore: Run rustfmt Merge pull request rustwasm#392 from fitzgen/child-process-and-output-management Child process and output management Merge pull request rustwasm#401 from drager/return-failure-error Return `Result<T, failure::Error>` instead of `Result<T, wasm_pack::error::Error>` v0.5.1 Merge pull request rustwasm#404 from rustwasm/0.5.1 v0.5.1 feat(website): bump vers Merge pull request rustwasm#405 from rustwasm/website-update feat(website): bump vers test(command/build): add a test for build command useing local wasm-bindgen Fix typo in test function name for copying the README bugfix(bindgen-target-dir): use PathBuf to join the old code are hard coded path with "/", which may cause error on windows, thus changing to use PathBuf.join. fixing rustwasm#414 change for cargo_metadata Merge branch 'master' into test-build-for-example Merge pull request rustwasm#408 from huangjj27/test-build-for-example test(command/build): add a test for build command Merge pull request rustwasm#412 from mstallmo/typo-fix Fix typo in test function name for copying the README Merge branch 'master' into fix-canonical-paths-on-windows this change is not related to this PR use absolutize remove unused use cargo fmt
Closes #393
I switched the level displayed in the progress bar from
PBAR.warntoPBAR.infoand changed the format closure fromwarn_formattoinfo_formatfor consistency.How the new terminal output looks:
Make sure these boxes are checked! 📦✅
rustfmtinstalled and have yourcloned directory set to nightly
$ rustup override set nightly $ rustup component add rustfmt-preview --toolchain nightlyrustfmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨