-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support no-modules #327
Merged
+102
−1
Merged
support no-modules #327
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
64c5a22
feat(bindgen): accept no-modules as target
ashleygwilliams 1985db3
feat(manifest:npm): add nomodules manifest struct
ashleygwilliams d79349e
feat(manifest): build no_modules npmpkg
ashleygwilliams 286bed9
test(no-modules): no-modules works
ashleygwilliams 120236f
fix(style): appease cargo fmt
ashleygwilliams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,16 @@ | ||
mod commonjs; | ||
mod esmodules; | ||
mod nomodules; | ||
pub mod repository; | ||
|
||
pub use self::commonjs::CommonJSPackage; | ||
pub use self::esmodules::ESModulesPackage; | ||
pub use self::nomodules::NoModulesPackage; | ||
|
||
#[derive(Serialize)] | ||
#[serde(untagged)] | ||
pub enum NpmPackage { | ||
CommonJSPackage(CommonJSPackage), | ||
ESModulesPackage(ESModulesPackage), | ||
NoModulesPackage(NoModulesPackage), | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
use manifest::npm::repository::Repository; | ||
|
||
#[derive(Serialize)] | ||
pub struct NoModulesPackage { | ||
pub name: String, | ||
#[serde(skip_serializing_if = "Vec::is_empty")] | ||
pub collaborators: Vec<String>, | ||
#[serde(skip_serializing_if = "Option::is_none")] | ||
pub description: Option<String>, | ||
pub version: String, | ||
#[serde(skip_serializing_if = "Option::is_none")] | ||
pub license: Option<String>, | ||
#[serde(skip_serializing_if = "Option::is_none")] | ||
pub repository: Option<Repository>, | ||
#[serde(skip_serializing_if = "Vec::is_empty")] | ||
pub files: Vec<String>, | ||
pub browser: String, | ||
#[serde(skip_serializing_if = "Option::is_none")] | ||
pub types: Option<String>, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in this PR, but as a follow up issue, this seems like a good candidate for an
enum
withFromStr
andDisplay
impls like how we do withBuildMode
andAccess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i was thinking about this when i ran into it, i'll file an issue for a refactor