Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always ‘color’ with cargo build. #293

Closed
wants to merge 1 commit into from
Closed

Always ‘color’ with cargo build. #293

wants to merge 1 commit into from

Conversation

jtomschroeder
Copy link

Always color cargo's output - #288

@fitzgen
Copy link
Member

fitzgen commented Sep 10, 2018

@alexcrichton could you review this PR? I'm unfamiliar with cargo's color and whether this fix is too heavy handed or what.

@alexcrichton
Copy link
Contributor

Thanks for this! Unfortunately though this won't fix the issue for a number of use cases :(

While this will force cargo/rustc to turn on colors, because the output is still captured via a pipe it's always colored using ANSI escape codes. That means that Windows console users won't get colors but rather seemingly garbled text (as the escape codes are printed). Additionally on Unix if wasm-pack's output is piped to a file then colors should also be disabled.

This bug may be solved as well if #287 is implemented

@jtomschroeder
Copy link
Author

Oh yeah, that makes sense. #287 would be great.

@ashleygwilliams
Copy link
Member

@alexcrichton does this solve enough to be worth merging (i understand it won't solve everything, but how good of an improvement is it?)

@alexcrichton
Copy link
Contributor

I would personally think no because this makes the compiler experience worse on Windows by accident

@ashleygwilliams
Copy link
Member

ok- sorry @jtomschroeder - thank you so much for giving it a try, and please feel free to grab another "help wanted" issue <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants