-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add toml like configuration #194
Conversation
@csmoe when you feel it's good for review just ping us :) I also just wanted to say I'm super stoked for this so thank you for working on it. |
65a8712
to
cc42c6e
Compare
Is this actually still WIP? Or waiting on review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know whether the manifest
module existed at the time this PR was written or not, but that seems to me like the "proper" location for this configuration parsing code.
@fitzgen those changes were introduced into |
@csmoe if i am correct this is waiting on #216 ? if so, you can rebase onto that branch and then change the PR to be into that PR so we can be ready to merge when that lands (ideally today). thank you so much for all your hard work and especially for your patience! additionally, i think we'll want some very basic docs and tests for this. lemme know if you want some direction on that. |
@ashleygwilliams yes, I'm waiting for |
for (key, value) in table { | ||
match (key.as_str(), value.clone()) { | ||
("debug", Value::Boolean(b)) => wasm_pack_config.debug = From::from(b), | ||
("features", Value::Array(a)) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how does features work?
@ashleygwilliams impl From<Features> for CargoTomlFeaturesSection?
@ashleygwilliams seems suppressed by #440, so close this? |
Address #160
Config format: (from #160 (comment)):
build_mode = debug | profiling | production