fix: allow npm binary upgrades #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of the NPM
binary-installpackage thatwasm-packuses stores binaries at an unversioned path in thebinary-installpackage's directory.This silently prevents version upgrades, as when upgrading to a different version of
wasm-pack,binary-installbelieves thewasm-packbinary is already installed, and keeps using the old one. For example, upgrading the NPMwasm-packpackage from0.12.1to0.13.0will continue using the0.12.1binary, and so has no effect (likely without the user noticing).This moves the install directory to
node_modules/wasm-pack/binary/, which should fix the issue.