feat(error_msg): Make custom module for errors #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does two big things: - We add custom error messages and conversions from other error types into our own error type. This means we can create or modify more fine grained errors rather than using whatever `failure::Error` gives us. The first one we have is a `Cli` error, whereby calls to things like wasm-bindgen or npm failed. - We also make it so that `PBAR.error()` is called only on exit. We grab a reference to whatever error gets passed up the chain, have it generate a message to be printed as an error to PBAR, close up PBAR like normal, and then print our actual error message to stderr! The main benefits of this is that as long as we return an error, PBAR will print and close itself up and we don't need to call it every time or forget that we would need to call it, and we put error details specifically into our error! Closes #12
|
Example output:
|
ashleygwilliams
approved these changes
May 2, 2018
|
Awesome! Glad you liked that refactor of error handling a bit! :D Another issue down! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does two big things:
into our own error type. This means we can create or modify more
fine grained errors rather than using whatever
failure::Errorgivesus. The first one we have is a
Clierror, whereby calls to thingslike wasm-bindgen or npm failed.
PBAR.error()is called only on exit. We graba reference to whatever error gets passed up the chain, have it
generate a message to be printed as an error to PBAR, close up PBAR
like normal, and then print our actual error message to stderr!
The main benefits of this is that as long as we return an error, PBAR
will print and close itself up and we don't need to call it every time
or forget that we would need to call it, and we put error details
specifically into our error!
Closes #12
Make sure these boxes are checked! 📦✅
rustfmtinstalled and have yourcloned directory set to nightly
$ rustup override set nightly $ rustup component add rustfmt-preview --toolchain nightlyrustfmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨