Do not warn about missing license files if the crate is explicitly unlicensed #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm-packemits a warning/information if thelicensefield is either missing from aCargo.tomlor specified but a correspondingLICENSE*file is missing. This is the right behavior for most cases, however, some (e.g., proprietary) crates are explicitly unlicensed in which case this message adds extra clutter to build processes.There seem to be two prevalent ways to indicate an unlicensed crate within the license field / SPDX license expressions:
NONEas declared in the spec.LicenseRef-Noneis also used for this purpose.This PR suppresses the information message about missing license files if either value is found in the
Cargo.toml's license field.