Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same syntax for extra arguments as wasm-pack test #1037

Merged
merged 3 commits into from
Aug 7, 2021

Conversation

fkettelhoit
Copy link
Contributor

The syntax for passing extra arguments to wasm-pack build and wasm-pack test has diverged due to #851, with the result that an additional -- is expected by wasm-pack build but not by wasm-pack test:

wasm-pack build -- --features foo
wasm-pack test --features foo

This PR mirrors the change made in #851 and applies it to wasm-pack build so that both commands use the same syntax again (without the need for an extra -- and with the same syntax as cargo build and cargo test):

wasm-pack build --features foo
wasm-pack test --features foo

Make sure these boxes are checked! 📦✅

  • You have the latest version of rustfmt installed
$ rustup component add rustfmt
  • You ran cargo fmt on the code base before submitting
  • You reference which issue is being closed in the PR text

✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨

@drager drager merged commit 34d8aa9 into rustwasm:master Aug 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants