Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that wasm-pack supports --target no-modules in --help #416

Closed
fitzgen opened this issue Oct 18, 2018 · 5 comments
Closed

Document that wasm-pack supports --target no-modules in --help #416

fitzgen opened this issue Oct 18, 2018 · 5 comments
Milestone

Comments

@fitzgen
Copy link
Member

fitzgen commented Oct 18, 2018

💡 Feature description

wasm-pack should expose wasm-bindgen's no-modules mode as a --target no-modules option.

More info:

💻 Basic example

wasm-pack build --target no-modules
@fitzgen fitzgen added enhancement New feature or request feature request labels Oct 18, 2018
@ashleygwilliams ashleygwilliams added help wanted Extra attention is needed good first issue Good for newcomers to-do stuff that needs to happen, so plz do it k thx hacktoberfest and removed enhancement New feature or request feature request labels Oct 18, 2018
@ashleygwilliams ashleygwilliams added this to the 0.6.0 milestone Oct 18, 2018
@mstallmo
Copy link
Member

mstallmo commented Oct 18, 2018

@fitzgen I was just taking a look at this and as far as I can tell it looks like this functionality is implemented in bindgen.rs it's just not documented when running wasm-pack build --help. Is this correct or did I miss some more work that needs to be done?

@ashleygwilliams
Copy link
Member

lol whoops, i totally implemented this. we just need to doc it 😅 64c5a22

@ashleygwilliams
Copy link
Member

actually also it's documented: https://rustwasm.github.io/wasm-pack/book/commands/build.html#target

closing

@mstallmo
Copy link
Member

Would this be something we want to add to the —help print out for the build command or is it okay as is?

Currently the help flag only displays browser and nodejs as valid options for target.

@fitzgen
Copy link
Member Author

fitzgen commented Oct 23, 2018

Would this be something we want to add to the —help print out for the build command or is it okay as is?

Currently the help flag only displays browser and nodejs as valid options for target.

Oh yes, we totallly need to do this.

This is why I thought it wasn't supported and had this weird deja vu feeling :-p

@fitzgen fitzgen reopened this Oct 23, 2018
@fitzgen fitzgen changed the title wasm-pack should support --target no-modules Document that wasm-pack supports --target no-modules in --help Oct 23, 2018
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Oct 23, 2018
fitzgen added a commit to fitzgen/wasm-pack that referenced this issue Oct 29, 2018
@ashleygwilliams ashleygwilliams added changelog - docs changelog - fix and removed good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed to-do stuff that needs to happen, so plz do it k thx changelog - docs labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants