Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix web-sys build on some Windows builds #944

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix web-sys build on some Windows builds #944

merged 1 commit into from
Oct 8, 2018

Commits on Oct 8, 2018

  1. Fix web-sys build on some Windows builds 

    The official pathname separator on Windows is `\` instead of `/`, but
we've been unconditionally using `/`. This typically works on Windows
because Cargo's default `OUT_DIR` listing is a normal `C:\...` path
which works with either `/` or `\`. If, however, a user sets
`CARGO_TARGET_DIR` to a UNC-style path like `\\?\C:\...` then `/` is
*not* the same as `\`, but rather `/` is interpreted as part of the file
name (to allow file names with `/` in the name).

Let's bypass all this and just use a build script output env var.

Closes rustwasm#943
    @alexcrichton
    alexcrichton committed Oct 8, 2018
    Configuration menu
    Copy the full SHA
    18deb5e View commit details
    Browse the repository at this point in the history