Remove WASM_BINDGEN_THREADS_MAX_MEMORY and WASM_BINDGEN_THREADS_STACK_SIZE
#4363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxpedda
force-pushed
the
thread-size
branch
from
543562d to
0257f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when compiling with
atomics, the maximum memory size can be set viaWASM_BINDGEN_THREADS_MAX_MEMORYand the stack size of a thread can be set viaWASM_BINDGEN_THREADS_STACK_SIZE.Both are not needed anymore. The maximum memory size can be set via
-Clink-arg=--max-memory=<size>. The stack size of a thread can be set when initializing the thread via thedefaultfunction, which was introduced in #3995.Additionally, I removed the
WASM_BINDGEN_THREADS, which would not actually set the memory toshared, making it just set a maximum memory size without any real useful other effect.