Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code #4300

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Remove dead code #4300

merged 1 commit into from
Dec 6, 2024

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Nov 29, 2024

The code changes here should most definitely not cause any observable changes to runtime behavior.
However, instead they unfortunately cause memory allocation errors (for more info see CI), presumably caused by some UB somewhere.

@daxpedda daxpedda added the help wanted We could use some help fixing this issue! label Nov 29, 2024
@daxpedda daxpedda marked this pull request as ready for review November 29, 2024 19:00
@daxpedda daxpedda removed the help wanted We could use some help fixing this issue! label Dec 6, 2024
@daxpedda
Copy link
Collaborator Author

daxpedda commented Dec 6, 2024

Figured it out: I removed a bool parameter from a function that had 2 bool parameters and deleted the wrong bool at the call site. 🤦

@daxpedda daxpedda merged commit 04edcff into rustwasm:main Dec 6, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant