-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version v0.2.85 breaks stdweb, possibly due to a breaking change #3415
Comments
This is an issue with the update to Obviously, this could be fixed by not using bare trait objects in |
dtolnay confirmed that this is intentional behavior by So nothing really can be done about this. Downgrading to |
- This fixes the error message loss (shadowed by an error complaining about `::core` not found) for 2015 edition callers when the callee was using `Error::new_spanned` over the caller's input tokens (since this would then *resolve* `::core` using the caller's edition). - an example: rustwasm/wasm-bindgen#3415 (comment) complains about `unresolved import` while pointing to an open parenthesis. - More generally, it is more correct to only tweak the `located_at` aspect of spans when dealing with a `compile_error!` invocation.
Describe the Bug
Building a project which depends on
stdweb-0.4.20
works fine onwasm-bindgen-0.2.84
but doesn't onwasm-bindgen-0.2.85
, it fails with this message:Is it possible that this version could have introduced a breaking change?
Steps to Reproduce
cargo build --target wasm32-unknown-unknown
and see the error:wasm-bindgen = "=0.2.84"
cargo build --target wasm32-unknown-unknown
and see that it now builds with the older version of wasm-bindgen.This is a minimal example showing that
stdweb
breaks on the new update towasm-bindgen
. If you want a real-world example of this breaking, see modmark-org/modmark#300 where the build failed due to the update. Feel free to clonemodmark-org/modmark
and docd playground && ./build-playground
and see the build fail. Then, changeplayground/web_bindings/Cargo.toml
towasm-bindgen = "=0.2.84"
and see it succeed.Expected Behavior
I would have expected that
0.2.85
wouldn't break0.2.84
and that everything that compiles under0.2.84
would also compile under0.2.85
Actual Behavior
stdweb
doesn't build under0.2.85
The text was updated successfully, but these errors were encountered: