-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gloo-timers: don't consume callback in Interval closure #57
Conversation
…nterval only works on first callback and fails after that
Could we also add a test that triggers this bug? |
@OddCoincidence yep working on tests now. As it happens integration tests are not running in CI, which is why it's reporting that these changes are okay here, when in fact fixing the bug actually causes the |
@OddCoincidence alright I wrangled the tests. Hope you don't mind but I did a little bit of re-jiggery once I understood how they worked to simplify them a little. The The |
0fbfa4d
to
f7858fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great with one nitpick to fix before we merge this; thanks @samcday!
f7858fe
to
1bd3f75
Compare
…vals fire more than once
1bd3f75
to
7749e20
Compare
Sweet, feedback addressed. Looks like CI is running headless tests now too, nice! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Otherwise Interval only works on first callback and fails after that