Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add advisory for buffered-reader #1697

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

nwalfield
Copy link
Contributor

Attacker-controlled input can lead to an out-of-bounds index, which causes buffered-reader to panic. This has been fixed in versions 1.2.0, 1.1.5, and 1.0.2 of buffered-reader.

@nwalfield
Copy link
Contributor Author

CI is failing with:

12 | [versions]
   | ^^^^^^^^^^
bad parameter: Overlapping version ranges: [1.0.2, 2.0.0-0) and [1.1.5, 2.0.0-0)

I have:

[versions]
patched = [">= 1.2.0"]

# The fixes were backported to these versions (1.0.1 is in Debian
# Stable and 1.1.4 is in Debian Testing).
unaffected = ["1.0.2", "1.1.5"]

I guess that is wrong. I'd appreciate help for articulating that all versions are affected except 1.2.0, 1.1.5 and 1.0.2, which I just released and include the required fixes.

Copy link
Member

@amousset amousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting these! This should be the correct way to indicate these version ranges.

@nwalfield
Copy link
Contributor Author

Thanks for the help. I indeed misunderstood the meaning of unaffected. I think your suggestions are reasonable. If no one else gets to it by Tuesday, then I'll do it then, I'll submit an updated patch.

Attacker-controlled input can lead to an out-of-bounds index, which
causes buffered-reader to panic.  This has been fixed in versions
1.2.0, 1.1.5, and 1.0.2 of buffered-reader.
@amousset amousset merged commit 8a7fc61 into rustsec:main May 31, 2023
1 check passed
@nwalfield nwalfield deleted the buffered-reader branch May 31, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants