Add unsound mozjpeg
#1389
Merged
Add unsound mozjpeg
#1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pinkforest <[email protected]>
5 tasks
There was a problem hiding this comment.
Factually looks good. Style nit: The text refers to an explanation from RUSTSEC-2020-0029 but there's no link to it, I don't know how this is usually handled. As an alternative, the explanation could be inlined. Suggestion:
Affected versions of mozjpeg crate allow creating instances of any type
Tfrom bytes,
and do not correctly constrainTto the types for which it is safe to do so.
Examples of safety violation possible for a typeT:
Tcontains a reference type, and it constructs a pointer to an invalid, arbitrary memory address.Trequires a safety and/or validity invariant for its construction that may be violated.
Signed-off-by: pinkforest <[email protected]>
|
Thanks - we use EDIT: Also added link in the .md EDIT.2: Also added function signature |
Signed-off-by: pinkforest <[email protected]>
Signed-off-by: pinkforest <[email protected]>
Signed-off-by: pinkforest <[email protected]>
Signed-off-by: pinkforest <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #327
ImageOptim/mozjpeg-rust#10
@HeroicKatora would you mind reviewing this ? thx