-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deny config #277
Update deny config #277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 97.30% 97.30%
=======================================
Files 19 19
Lines 4237 4237
=======================================
Hits 4123 4123
Misses 114 114 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! The [advisories]
section changes LGTM. I think the [licenses]
change is probably OK too, but wanted to make sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't realise we had cargo-deny going here -- I guess it's a carry over from the original version. Note the "We don't maintain a fixed Cargo.lock so enforcing ..." comment near the bottom of this file is now obsolete.
Yup, it was first added by Brian in December of 2020.
Removed the comment and flipped the setting to |
cargo-deny got updated and changed some configuration stuff: