Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deny config #277

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Update deny config #277

merged 2 commits into from
Aug 5, 2024

Conversation

djc
Copy link
Member

@djc djc commented Aug 3, 2024

cargo-deny got updated and changed some configuration stuff:

djc-2021 main webpki $ cargo deny check licenses
error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
  ┌─ /Users/djc/src/webpki/deny.toml:2:1
  │
2 │ unmaintained = "deny"
  │ ━━━━━━━━━━━━

error[deprecated]: this key has been removed, see https://github.com/EmbarkStudios/cargo-deny/pull/611 for migration information
  ┌─ /Users/djc/src/webpki/deny.toml:4:1
  │
4 │ notice = "deny"
  │ ━━━━━━

2024-08-03 15:03:31 [ERROR] failed to validate configuration file /Users/djc/src/webpki/deny.toml

@djc djc requested review from cpu and ctz August 3, 2024 15:05
Copy link

codecov bot commented Aug 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (1414bf4) to head (2e1f2f5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   97.30%   97.30%           
=======================================
  Files          19       19           
  Lines        4237     4237           
=======================================
  Hits         4123     4123           
  Misses        114      114           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The [advisories] section changes LGTM. I think the [licenses] change is probably OK too, but wanted to make sure.

deny.toml Show resolved Hide resolved
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't realise we had cargo-deny going here -- I guess it's a carry over from the original version. Note the "We don't maintain a fixed Cargo.lock so enforcing ..." comment near the bottom of this file is now obsolete.

@djc
Copy link
Member Author

djc commented Aug 5, 2024

Didn't realise we had cargo-deny going here -- I guess it's a carry over from the original version.

Yup, it was first added by Brian in December of 2020.

Note the "We don't maintain a fixed Cargo.lock so enforcing ..." comment near the bottom of this file is now obsolete.

Removed the comment and flipped the setting to multipe-versions = "false".

@djc djc added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 6cd6d03 Aug 5, 2024
58 checks passed
@djc djc deleted the deny-update branch August 5, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants