Fix windows build #235
Merged
Fix windows build #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 19 19
Lines 4336 4336
=======================================
Hits 4212 4212
Misses 124 124 ☔ View full report in Codecov by Sentry. |
|
I think the various CI |
|
Oh! Yes good point. |
djc
approved these changes
Feb 22, 2024
ctz
force-pushed
the
jbp-fix-windows-build
branch
from
5781239
to
a7728af
Compare
cpu
reviewed
Feb 22, 2024
cpu
approved these changes
Feb 22, 2024
This is up to date, apart from `windows_x86_64_msvc` (etc.) versions.
ctz
force-pushed
the
jbp-fix-windows-build
branch
from
a7728af
to
b79bc3c
Compare
djc
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Cargo.lock to avoid some broken versions of windows platform crates.
Also ninja-build installation step for windows. I don't think that is strictly necessary (because nothing sets the aws-lc-rs/fips feature here), but also is very low cost.