Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pki-types ServerName #207

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Migrate to pki-types ServerName #207

merged 2 commits into from
Nov 23, 2023

Conversation

djc
Copy link
Member

@djc djc commented Nov 21, 2023

Prerequisites:

One benefit is that this makes IP address validation accessible to no_std environments.

@djc djc requested review from cpu and ctz November 21, 2023 11:21
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (24facb0) 96.77% compared to head (751a81f) 97.21%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/subject_name/dns_name.rs 89.47% 2 Missing ⚠️
src/end_entity.rs 90.90% 1 Missing ⚠️
src/error.rs 0.00% 1 Missing ⚠️
src/subject_name/ip_address.rs 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   96.77%   97.21%   +0.43%     
==========================================
  Files          20       19       -1     
  Lines        4774     4266     -508     
==========================================
- Hits         4620     4147     -473     
+ Misses        154      119      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc djc force-pushed the pki-server-name branch 3 times, most recently from 735061e to 6a1d93f Compare November 21, 2023 11:30
src/end_entity.rs Outdated Show resolved Hide resolved
src/end_entity.rs Outdated Show resolved Hide resolved
@djc djc force-pushed the pki-server-name branch 3 times, most recently from ea0c317 to 5d67b62 Compare November 23, 2023 09:18
@djc djc added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit eed037b Nov 23, 2023
57 of 58 checks passed
@djc djc deleted the pki-server-name branch November 23, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants