extensions: parse CRL issuing distribution point. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
chifflier
approved these changes
Feb 5, 2024
|
Thanks for the review :-) Your feedback seems reasonable. I can integrate it over the next day or so. |
This is helpful for folks in the JetBrains ecosystem (CLion, Rust-Rover, etc).
Prior to this commit the x509-parser extension parsing code recognized *certificate* CRL distribution points extensions, but not the corresponding *CRL* issuing distribution point extension. This commit adds the missing support, leveraging the existing code for parsing distribution point name fields and revocation reason fields.
|
@chifflier I've addressed your feedback and I think this is ready for another review when you have a chance. Thanks. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this branch the x509-parser extension parsing code recognized the certificate CRL distribution points extension (RFC 5280 Section 4.2.1.13), but not the corresponding CRL issuing distribution point extension (RFC 5280 Section 5.2.5).
This commit adds the missing support, leveraging the existing code for parsing distribution point name fields and revocation reason fields.