Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Coding Guidelines] Add meeting minutes 2024-12-04 #117

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

vapdrs
Copy link
Contributor

@vapdrs vapdrs commented Dec 4, 2024

Feel free to suggest changes if I didn't properly capture anyone's proposals or questions

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking the minutes today. Leaving to @PLeVasseur to approve.

Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vapdrs -- thanks for capturing the minutes!

I put a couple of notes about potential, far from now changes, to the unsafe keyword I vaguely mentioned if you wanted to provide that context.

@vapdrs vapdrs requested a review from PLeVasseur December 5, 2024 14:58
Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vapdrs! LGTM

@PLeVasseur PLeVasseur added documentation Improvements or additions to documentation coding guidelines Related to work in the Coding Guidelines Subcommittee labels Dec 5, 2024
@PLeVasseur PLeVasseur merged commit 231bbf2 into rustfoundation:main Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coding guidelines Related to work in the Coding Guidelines Subcommittee documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants