Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

📝 add build instructions for fedora #23

Closed

Conversation

sylvain-reynaud
Copy link

@sylvain-reynaud sylvain-reynaud commented Mar 16, 2023

Closes #22

How to test it ?

docker run -it fedora bash

Then

ls /usr/lib/        #no gcc
dnf groupinstall "Development Tools" "Development Libraries"
ls /usr/lib/gcc/x86_64-redhat-linux/12/include/        #installed
git clone https://github.com/sylvain-reynaud/llama-rs
cd llama-rs/
curl https://sh.rustup.rs -sSf | sh
source "$HOME/.cargo/env"
cargo build --release        #still fails
CPATH="/usr/lib/gcc/x86_64-redhat-linux/12/include/" cargo build --release        #success

@philpax
Copy link
Collaborator

philpax commented Mar 22, 2023

Is this still necessary after #28 ?

@setzer22
Copy link
Collaborator

setzer22 commented Mar 22, 2023

I made a quick test. Installing a C compiler is still necessary, but none of the additional steps apply anymore since we got rid of bindgen (specifically, setting CPATH).

I would say including instructions in the README to make people aware they need a C compiler should be enough. But we can also provide some distro-specific commands. Similar to dnf groupinstall "Development Tools" "Development Libraries", ubuntu has the build-essential package for example.

Doing something for #20 would also help a lot in making this less compilicated, since people can just download the binary then.

@philpax philpax added the issue:documentation Improvements or additions to documentation label Mar 24, 2023
@philpax
Copy link
Collaborator

philpax commented Mar 26, 2023

Closing this as #73 should address it. (Please let me know/send a PR if it doesn't!)

@philpax philpax closed this Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

broken build on fedora
3 participants