Fix: mobile -> wayland virtual keyboard mapping mismatch #6328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5193
Works for android + ios
Non ASCII characters will still not work (doesn't work on desktop -> wayland too)
ios_key.mp4
android_key.mp4
Notes for review:
Currently we only support physical key input emulation on wayland. So I have updated mappings to support characters that requires to press
shift+key
.Non ASCII characters works on mobile -> x11 because
xdo
supports unicode input. I tried usingxdo
but it has bad compatibility with xwayland, it didn't work for me at all.I tried other alternatives like wtype and ydotool.
wtype
supports unicode but has bad compatibility as it relies onvirtual-keyboard
protocol which is not well adapted by many wayland compositors yet.ydotool
works on all wayland environments. It uses uinput like us but it has wider mappings support, so I just updated the mappings in our implementation.ydotool
does not support non ASCII characters either.