Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error applet support + error applet panic hook #162
Add error applet support + error applet panic hook #162
Changes from 9 commits
dc29593
a75ac1f
cd30981
a9ded19
c6d5cdc
d32cd15
17dc4c4
a67c8c0
a65b9ed
d630c25
5cec437
6da884e
ffbe660
efbf913
559c757
b967440
9396939
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I kind of liked the ErrorApplet name from before, but this works I guess. If not the original name, maybe it could be clearer that it's a pop up message.
PopUpMessage
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check my understanding, this will block the app until the popup is closed, and then the app will quit (since there's no
loop
or anything)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, you've got that right. Though the app can technically continue if the panic is stopped by a thread boundary or
catch_unwind
or whatever.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really interesting! Similar to what I mentioned in #166 , maybe we can just force these constants to generate using
errorReturnCode
as the type instead ofc_int
?To catch the struct size/alignment issues, I wonder if we could have caught that using bindgen's layout tests. I think they were omitted before because we didn't have any good way to run them, but with
test-runner
now we might be able to actually do it in CI. I'll file an issue (edit: #167)Edit:
bindgen
also has a.fit_macro_constants(true)
we could try to use for this purpose, but I'm not sure if it would help with the actual struct size.