-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Camera rework and small fixes #137
Conversation
It seems like nobody on github ever used stereo calibration before (not even devkitPro's own examples include it) nor image quality calibration. In my tests it seems like @Steveice10 Sorry for the tag, but since you've written the |
Thank you so much for the information! I didn't expect your quick response 😄.
Interesting. This effectively means I'd need to re-implement all IPC calls to use my own
No problem, I've already been experimenting with it enough. I should be able to find some conclusive evidence in no time, i hope... I guess I should try to merge this PR more or less as-is and work on re-implementing everything over |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have a chance to deeply read the new camera code yet but mostly LGTM! Couple minor comments but otherwise all seems good
This PR is finally ready to merge. |
Co-authored-by: Ian Chamberlain <[email protected]>
Big (and messy) PR incoming!
Changes related to the
cam
service:cam
functions to fix weird behaviour or crashes and to streamline the service. Still WIP (Trimming still needs some research and the image calibration configs don't seem to work).BothOutwardCam
using a specifictake_picture
implementation.camera-image
example now takes 3D images (and is abnormally slow thanks to CPU rendering).camera-image
example doesn't need all the specificconst
values to work properly.Some other minor changes that were made in the mean time:
Console::set_window
.Hid
module, such as volume slider and accelerometer/gyroscope. After some more research (done for the changes) I noticed the service requires to be exclusively usable from one instance, usingServiceReference
, as it modifies global states which are normally un-trackable.ServiceReference
checks for service usage. Poison handling is now a feature!panic!
cases that are now handled as newError
types. (also renamedNdspError
to justError
following the module namespaces changes)Gfx
on the VRAM.P.S.
I'm sorry for mixing up the changes to the cam service and those related to TODO or other small fixes. I had initially envisioned this PR as a "todo fix" PR but as I worked on it I noticed that
cam
was going to need a lot of work.