-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation and examples #134
Conversation
When I check out the branch and run
|
You probably need to update your git cache. It’s been updated a while ago. |
That's the thing though, I can build and read the docs just fine on the latest |
I don’t really know what to tell you except |
Got them building after nuking my local project and then checking the branch out again. Not sure what that was about but at least the problem's gone now 😆 |
Other than typos and some suggestions from Github Actions that might be worth implementing, I'd say that this looks good to me |
Co-authored-by: FenrirWolf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the things I saw from Github Actions weren't actually caused by this PR so they don't need to block it. I think this looks good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great job! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, awesome work!!! This is really a huge step forward for the library and looks like it took a lot of effort, so thank you!
Many of my comments are just little typos or minor wording change suggestions, so feel free to ignore them as you want. I probably missed some stuff but I tried to look at everything I could, so hopefully some of it is helpful.
This is really exciting!
Co-authored-by: Ian Chamberlain <[email protected]>
Co-authored-by: Ian Chamberlain <[email protected]>
Co-authored-by: Ian Chamberlain <[email protected]>
Closes #32
Finally, the long awaited "documentation PR" I have so much anticipated has come.
This PR's changes boil down to:
Cargo.toml
manifests to include all metadata required for a future release on crates.io.#[doc(alias)]
for ALL functions and structs that benefit a 1:1 relation withctru-sys
, so that users used to the C library can search for names they already know and find out how that functionality translates inctru-rs
.cargo-3ds
).And most importantly:
I suggest you review this PR mostly by looking at the result of the
cargo 3ds doc
compilation, since the git diff is huge.This PR took me weeks of work and it marks one big milestone for this project (in some cases, the new docs are actually better than
libctru
's official ones :P ).Thanks for your attention. I may finally go puke in a nearby bucket. Writing docs is nauseous 🤮 .