Winit version 0.30.5 #3849
Merged
Winit version 0.30.5 #3849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
requested review from
notgull,
daxpedda,
madsmtm and
MarijnS95
as code owners
`clippy::doc_lazy_continuation` was added, which needed some fixing from our side.
This type comes from the user and stored for the entire lifetime, so no need to hide it from them after they've passed it to winit. Fixes #3818.
This was detected by a new change in Nightly Rust that applied `#[must_use]` to the return value of `Box::into_raw()`.
Prevent assertion error when trying to close a fullscreen window that was on a display that got disconnected.
kchibisov
force-pushed
the
kchibisov/release-0305
branch
from
f7c4189
to
2858262
Compare
This was referenced Aug 7, 2024
|
Hiya! Would it by chance be possible to include 15b79b1 as well? That's blocking egui from going past 0.30.2 as it can't read the current system theme since 0.30.3. Don't know what the process is but figured I'd ask, thank you :) |
|
I've excluded it because it changed behavior a bit, but given that old behavior was not entirely correct it's probably fine to add it. |
This also fixes macOS returning `None` in `Window::theme()` if no theme override is set, instead it now returns the system theme. MacOS and Wayland were the only ones working correctly according to the documentation, which was an oversight. The documentation was "fixed" now. Fixes #3837.
It has low amount of users and not active, so better direct people straight to matrix at this point.
kchibisov
force-pushed
the
kchibisov/release-0305
branch
from
2858262
to
95bdaa8
Compare
|
Perfect, thanks a bunch! |
daxpedda
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.