Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Android docs build on docs.rs #3236

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

madsmtm
Copy link
Member

@madsmtm madsmtm commented Nov 22, 2023

As discussed in #2324 (comment).

@madsmtm madsmtm added DS - android S - docs Awareness, docs, examples, etc. labels Nov 22, 2023
// docs, but it'll be very confusing for users to see the docs with that
// feature enabled, so we avoid inlining it so that they're forced to view
// it on the crate's own docs.rs page.
#[doc(no_inline)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't even know about this, that's cool!

@madsmtm madsmtm merged commit 5612626 into rust-windowing:master Nov 23, 2023
50 checks passed
@MarijnS95 MarijnS95 added this to the Version 0.29.4 milestone Nov 23, 2023
@MarijnS95
Copy link
Member

Added this to the 0.29.4 milestone for backporting.

@madsmtm madsmtm deleted the fix-android-docsrs branch November 23, 2023 10:52
kchibisov pushed a commit to kchibisov/winit that referenced this pull request Nov 24, 2023
kchibisov pushed a commit that referenced this pull request Nov 24, 2023
@madsmtm
Copy link
Member Author

madsmtm commented Nov 24, 2023

Seems like it worked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DS - android S - docs Awareness, docs, examples, etc.
Development

Successfully merging this pull request may close these issues.

2 participants