-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to objc2
#2427
Move to objc2
#2427
Conversation
Should we enable the "exception" feature? It seems unsound got exceptions to unwind into Rust. |
The feature flag is called Re soundness: That feature is just as unsound as letting exceptions unwind into Rust, since our message sending is implemented in Rust. Practically, I haven't enabled it because exceptions are rare, the user-experience approximately the same, and enabling it requires running Note that people can still enable it if they want by depending on |
67af56d
to
1c7e4c5
Compare
This is very close to where I want it to be, so I'll start opening smaller PRs. |
The compiler fence is safe to get rid of now since `interpretKeyEvents` takes `&mut self`
A sneak-peak at the improvements I've been working on for iOS and macOS.
Move to
objc2
, my fork ofobjc
which adds a lot of things, in particular macros for proper memory management, and a lot of fixed soundness issues.When done, this should vastly improve the safety and ease-of-maintenance of the iOS and macOS platforms. Opening this PR to have something to refer to, but will split it up into smaller parts when I'm ready to actually get it merged.
CHANGELOG.md
if knowledge of this change could be valuable to users