Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: Redraw immediately to prevent shaking on window resize #1901

Merged
merged 3 commits into from
Apr 6, 2021

Conversation

xiaopengli89
Copy link
Contributor

@ArturKovacs ArturKovacs self-requested a review April 4, 2021 19:22
@ArturKovacs
Copy link
Contributor

At a first glance this seems to be related to or a duplicate of #1812, but I'm going to give a proper review later.

@ArturKovacs
Copy link
Contributor

I was wrong, this addresses different problem than #1812.

Copy link
Contributor

@ArturKovacs ArturKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, but please add an entry to the CHANGELOG.md file, something like:

- On macOS, emit `RedrawRequested` events while the window is being resized.

@xiaopengli89
Copy link
Contributor Author

Alright, and thanks for your review.

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Markus Røyset <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Resize event is not emitted immediately/synchronously
3 participants