Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add accept_first_mouse for macOS #1882

Merged
merged 2 commits into from
Apr 30, 2021

Conversation

z4122
Copy link
Contributor

@z4122 z4122 commented Mar 14, 2021

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

On macOS, change the default behavior for first click when window was unfocused. Now window will become focused and then respond to the click event when mouse clicks.
To keep consistent with windows.

@ArturKovacs ArturKovacs self-requested a review March 14, 2021 21:56
Copy link
Contributor

@ArturKovacs ArturKovacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Welcome to winit and thanks for the contribution. 😊

It's looking good.

@ArturKovacs
Copy link
Contributor

@murarth if you take a look and this and approve it, then I'll be able to merge it. It works as expected so at this point just general code quality check is enough I believe.

@ArturKovacs
Copy link
Contributor

@z4122 if you fix the conflicts, I'll merge this without waiting for other maintainers.

Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, it matches what I would expect from a winit application!

At some point we should consider making it user-configurable, but let's wait until someone comes with a concrete use-case!

@ArturKovacs
Copy link
Contributor

I rebased onto the master, and force-pushed the changes.

@ArturKovacs
Copy link
Contributor

It's somewhat annoying that the "nightly-x86_64-pc-windows-gnu" target fails spuriously :/

@ArturKovacs ArturKovacs merged commit 0986fae into rust-windowing:master Apr 30, 2021
@mgax mgax mentioned this pull request Sep 2, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants