Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XNotSupported error unwrapped in EventLoop::new #3350

Closed
emilk opened this issue Jan 2, 2024 · 0 comments · Fixed by #3355
Closed

XNotSupported error unwrapped in EventLoop::new #3350

emilk opened this issue Jan 2, 2024 · 0 comments · Fixed by #3355
Labels
DS - x11

Comments

@emilk
Copy link
Contributor

emilk commented Jan 2, 2024

Instead of returning the XNotSupported error, it is unwraped, causing a panic.

winit/src/platform_impl/linux/mod.rs

Line 789 in c55a2c7

Backend::X => Ok(EventLoop::new_x11_any_thread().unwrap()),

@emilk emilk mentioned this issue Jan 2, 2024
Open
4 tasks
kchibisov added a commit to kchibisov/winit that referenced this issue Jan 3, 2024
@kchibisov
On X11, fix error propagation in EventLoop::new
660bd59 
Fixes rust-windowing#3350.
@kchibisov kchibisov mentioned this issue Jan 3, 2024
Merged
5 tasks
kchibisov added a commit that referenced this issue Jan 5, 2024
@kchibisov
On X11, fix error propagation in EventLoop::new
021fd23 
Fixes #3350.
kchibisov added a commit to kchibisov/winit that referenced this issue Jan 5, 2024
@kchibisov
On X11, fix error propagation in EventLoop::new
e47544e 
Fixes rust-windowing#3350.
kchibisov added a commit that referenced this issue Jan 5, 2024
@kchibisov
On X11, fix error propagation in EventLoop::new
fdedda3 
Fixes #3350.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
DS - x11
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On X11, fix error propagation in EventLoop::new kchibisov/winit
2 participants
@emilk @daxpedda