Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Fn key on Macbook logs an error #3246

Closed
emilk opened this issue Nov 28, 2023 · 6 comments · Fixed by #3247
Closed

Pressing Fn key on Macbook logs an error #3246

emilk opened this issue Nov 28, 2023 · 6 comments · Fixed by #3247

Comments

@emilk
Copy link
Contributor

emilk commented Nov 28, 2023

Pressing the Fn key on a MacBook keyboard (macOS Ventura 13.4.1) prints the following error:

[2023-11-28T12:46:14Z ERROR winit::platform_impl::platform::event] UCKeyTranslate was succesful but gave a string of 0 length.

@kchibisov
Copy link
Member

Which winit version? I think I fixed something like that in 0.29.4?

@kchibisov
Copy link
Member

Also, maybe it errors on some systems now (though, not for me), I just know that before 0.29.4 once you press Fn you get an assertion straight away.

@emilk
Copy link
Contributor Author

emilk commented Nov 28, 2023

I'm on 0.29.4

@emilk
Copy link
Contributor Author

emilk commented Nov 28, 2023

I suspect the log line should just be removed - not all key presses corresponds to a string, and that's fine.

@kchibisov
Copy link
Member

Yeah, it's just doesn't happen for me iirc and I can't update further 12 version. You could send a patch, should be fairly easy.

The start chain for that is from update flags stuff in macos platform.

@emilk
Copy link
Contributor Author

emilk commented Nov 28, 2023

It could be that I have two keyboard layouts (English and Swedish), and pressing Fn switches between the two.
In any case, a PR is incoming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants