Merged
Conversation
Member
Author
|
@MarijnS95 if you would review the API as it is currently, and tell me if you spot something odd, that'd be nice! |
MarijnS95
reviewed
Sep 9, 2024
Member
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe I can keep the API as it currently is stable for a long time. The only real outstanding question is #24, which I haven't done enough research on to figure out (and isn't really motivated enough to do, it's quite niche), and I believe that can be solved without breaking changes.
The current API is even compatible with future versions of
raw-window-handlethat may use different handles.