Conversation
Merged
MarijnS95
reviewed
Sep 9, 2024
Comment on lines
+256
to
+257
| // Unwrap is fine, `Retained` stores a non-null pointer | ||
| NonNull::new(Retained::into_raw(self.layer).cast()).unwrap() |
Member
There was a problem hiding this comment.
Guessing (given your PR description here about Box) that you might plan on changing the return type of Retained too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already use
NonNullin our public API in the creation methods, let's also use it when yielding back the value.This differs from
std'sBoxmethods, but I think that's fine,std's methods are from beforeNonNullwas introduced.