Implement priority hints for EGL #1700
Conversation
valaphee
force-pushed
the
context-priority
branch
from
656ab7f
to
2625fe2
Compare
valaphee
force-pushed
the
context-priority
branch
from
2625fe2
to
c63d6a8
Compare
| @@ -228,6 +241,8 @@ pub struct ContextAttributes { | |||
|
|
|||
| pub(crate) api: Option<ContextApi>, | |||
|
|
|||
| pub(crate) priority: Priority, | |||
There was a problem hiding this comment.
Given that drivers could confuse things, can we use Option internally here? So when it's None we don't push, but when it's e.g. Some(Medium) it's pushed to ensure the Medium.
| /// | ||
| /// # Api-specific | ||
| /// | ||
| /// - Only EGL at the moment implements context priorities. |
There was a problem hiding this comment.
I'd probably use the notation with not supported we use everywhere else, so say that glx, wgl, and cgl is not supported.
| attrs.push(match context_attributes.priority { | ||
| Priority::Low => egl::CONTEXT_PRIORITY_LOW_IMG, | ||
| Priority::High => egl::CONTEXT_PRIORITY_HIGH_IMG, | ||
| Priority::Realtime => { | ||
| if self.inner.display_extensions.contains("EGL_NV_context_priority_realtime") { | ||
| egl::CONTEXT_PRIORITY_REALTIME_NV | ||
| } else { | ||
| egl::CONTEXT_PRIORITY_HIGH_IMG | ||
| } | ||
| }, | ||
| _ => unreachable!(), | ||
| } as EGLint); |
There was a problem hiding this comment.
Put a match on a separate line please and then just push with as casting.
|
You need to add a |
I'm fine with adding such a check just for android target. |
Fixes #1645
Fixes #1694
This PR adds a way to specify the priority for contexts. I mostly used the term hint, as its not guaranteed for various reasons that the context actually gets the priority.
Don't know if it makes sense to guarantee the priority. In Chromium it's also only used as a hint.
I also probably should extend the extension check as it is not correctly reported on Android.
https://github.com/chromium/chromium/blob/main/ui/gl/gl_display.cc#L814
Theoretically the extension also exists for GLX but Mesa for example doesn't support it.
CHANGELOG.mdif knowledge of this change could be valuable to users