Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use get_instance_handle() over GetModuleHandle(NULL) #1446

Closed
wants to merge 1 commit into from
Closed

Use get_instance_handle() over GetModuleHandle(NULL) #1446

wants to merge 1 commit into from

Conversation

SamRodri
Copy link

See the winit discussion about this fix.

fixes #1445

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@SamRodri
Copy link
Author

I see that there is a major rewrite underway, maybe @kchibisov can copy this patch into his pull request?

@kchibisov
Copy link
Member

kchibisov commented Aug 23, 2022

Actually, I don't think I need this patch at all on my branch. I just need to use hinstance from the handle instead of that.

I'm not sure how I feel about adding this patch right now given that I'm unlikely to make a glutin release.

Is there a strong need for this patch or you can wait like a few more weeks and update to my rework given that it's nearly complete already?

@SamRodri
Copy link
Author

No rush on my part, I can depend on my fork until your update is released.

@kchibisov
Copy link
Member

kchibisov commented Sep 3, 2022

Handled in #1435.

@kchibisov kchibisov closed this Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ERROR_CLASS_DOES_NOT_EXIST opening window from DLL
2 participants