Cleanups for Clippy and Windows #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The associated constants on the integer types have been available since 1.43.0, so do not use the corresponding modules in std or core. Signed-off-by: Paolo Bonzini <[email protected]>
The paragraph refers to the two items in the previous numbered list, so it must not be indented. Signed-off-by: Paolo Bonzini <[email protected]>
bonzini
force-pushed
the
clippy
branch
2 times, most recently
from
56feda9 to
4174acb
Compare
4 tasks
bonzini
requested review from
alexandruag,
jiangliu and
roypat
as code owners
roypat
reviewed
Jan 28, 2025
Windows does not have PROT_READ or PROT_WRITE, remove them from PtrGuard's API and only reference them inside the `cfg` block. Signed-off-by: Paolo Bonzini <[email protected]>
roypat
approved these changes
Jan 28, 2025
roypat
requested review from
andreeaflorescu,
rbradford and
stefano-garzarella
stefano-garzarella
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Fix some more issues from clippy and let vm-memory compile on Windows.
Putting these two together because they is really no functional change.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.