Skip to content

fix: Remove 4096B chunk restriction of read/write_volatile_from/into #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 6, 2024
Merged

fix: Remove 4096B chunk restriction of read/write_volatile_from/into #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b58497
fix: Remove 4096B chunk restriction of read/write_volatile
roypat Jan 8, 2024
c4367c7
Merge branch 'main' into fix-4096-bytes
roypat Jan 11, 2024
3b51dc0
Merge branch 'main' into fix-4096-bytes
roypat Mar 4, 2024
0d46858
Merge branch 'main' into fix-4096-bytes
roypat Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@
### Changed
- [[#275](https://github.com/rust-vmm/vm-memory/pull/275)] Fail builds on non 64-bit platforms.
### Fixed
- [[#279](https://github.com/rust-vmm/vm-memory/pull/279)] Remove restriction from `read_volatile_from` and `write_volatile_into`
that made it copy data it chunks of 4096.

### Removed
### Deprecated

Expand Down
3 changes: 0 additions & 3 deletions src/guest_memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -724,8 +724,6 @@ pub trait GuestMemory {
// Check if something bad happened before doing unsafe things.
assert!(offset <= count);

let len = std::cmp::min(len, MAX_ACCESS_CHUNK);

let mut vslice = region.get_slice(caddr, len)?;

src.read_volatile(&mut vslice)
Expand All @@ -749,7 +747,6 @@ pub trait GuestMemory {
// Check if something bad happened before doing unsafe things.
assert!(offset <= count);

let len = std::cmp::min(len, MAX_ACCESS_CHUNK);
let vslice = region.get_slice(caddr, len)?;

// For a non-RAM region, reading could have side effects, so we
Expand Down