Fail build on non 64-bit targets #275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ablu
requested review from
alexandruag,
bonzini,
jiangliu and
roypat
as code owners
roypat
previously approved these changes
Dec 18, 2023
Member
|
Nice, thanks for picking this up! |
rbradford
previously approved these changes
Dec 18, 2023
Closed
As discussed on Slack and during sync meetings, we should make it explicit that we only support 64bit. While other architectures may be viable to support, currently we assume that usize == u64 and nobody expressed interest in 32bit support. Signed-off-by: Erik Schilling <[email protected]>
Author
|
rebased |
roypat
approved these changes
Mar 1, 2024
JonathanWoollett-Light
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on Slack and during sync meetings, we should make it explicit that we only support 64bit. While other architectures may be viable to support, currently we assume that usize == u64 and nobody expressed interest in 32bit support.
Closes: #225
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commitmessage has max 60 characters for the summary and max 75 characters for each
description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.